shellDBus: Fix FocusApp()

The appDisplay used to be accessible via the viewSelector, but
that is gone now. Commit c09c070b15 adjusted the code, but the
replacement uses a Main.overview.appDisplay accessor that never
existed, whoops.

Fix this by exposing a new selectApp() method directly on the
overview, so we don't have to shuffle the appDisplay through
controls → overviewActor → overview.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1891>

diff --git a/js/ui/overview.js b/js/ui/overview.js
index e6b3b261562dda99f84c1f312c8ce12740086029..529779ea8b4fc6f014ddc184d8867943c3b8d5d7 100644 (file)
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -642,6 +642,11 @@ var Overview = class {
         this.show(OverviewControls.ControlsState.APP_GRID);
     }
 
+    selectApp(id) {
+        this.showApps();
+        this._overview.controls.appDisplay.selectApp(id);
+    }
+
     runStartupAnimation(callback) {
         Main.panel.style = 'transition-duration: 0ms;';
 

diff --git a/js/ui/shellDBus.js b/js/ui/shellDBus.js
index 3028dfb68f0ab65c7f10c41da4502f07d1d6ac2a..39f142af95c64cd6707a5010b4d9c387fbbe9396 100644 (file)
--- a/js/ui/shellDBus.js
+++ b/js/ui/shellDBus.js
@@ -100,8 +100,7 @@ var GnomeShell = class {
     }
 
     FocusApp(id) {
-        this.ShowApplications();
-        Main.overview.appDisplay.selectApp(id);
+        Main.overview.selectApp(id);
     }
 
     ShowApplications() {